Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Fix link for managing roles #11178

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Mar 19, 2024

Description

Fix "manage roles" link to correctly link to the roles tab

Manual testing steps

  1. Within CMS, select Security
  2. Go to "Roles" tab and create a role
  3. Go back to Security
  4. Go to "Groups" tab
  5. Select any group
  6. Go to "Roles" tab (within group edit form)
  7. click "Manage Roles" link (this should take you to the main roles section)

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (behat tests will be added in an admin PR)
  • CI is green

SecurityAdmin::singleton()->Link('show/root#Root_Roles'),
_t('SilverStripe\\Security\\Group.RolesAddEditLink', 'Manage roles')
SecurityAdmin::singleton()->Link('roles'),
_t(__CLASS__ . '.RolesAddEditLink', 'Manage roles')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing 'SilverStripe\\Security\\Group.RolesAddEditLink' to __CLASS__ . '.RolesAddEditLink' is an unrelated refactoring - figured I should tidy that up while I'm in here.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works correctly

@emteknetnz emteknetnz merged commit 8aab888 into silverstripe:5.1 Mar 20, 2024
15 checks passed
@emteknetnz emteknetnz deleted the pulls/5.1/fix-manage-roles-link branch March 20, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants