Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Make deprecation enabled check faster #11053

Conversation

GuySartorelli
Copy link
Member

The dev environment check in CMS 4 is slow, since it checks the session before checking environment variables. We should skip that outright if deprecations are explicitly disabled.

Issue

@GuySartorelli
Copy link
Member Author

This has two approvals, I'm gonna merge.

@GuySartorelli GuySartorelli merged commit bbc6167 into silverstripe:4.13 Nov 17, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.13/fix-deprecation-enabled-check branch November 17, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants