Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing returns (fluent setter) #10942

Merged
merged 1 commit into from
Sep 12, 2023
Merged

added missing returns (fluent setter) #10942

merged 1 commit into from
Sep 12, 2023

Conversation

rasstislav
Copy link
Contributor

No description provided.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this.
In the future can you please supply a bit more information? There's nothing inherent about this PR that shows why they should be fluent methods. I ended up finding that setValue() is defined in DBField and the phpdoc says to return $this:

* @return $this
*/
public function setValue($value, $record = null, $markChanged = true)
{
$this->value = $value;
return $this;
}

@GuySartorelli GuySartorelli merged commit 9594444 into silverstripe:4.13 Sep 12, 2023
@rasstislav
Copy link
Contributor Author

Thanks @GuySartorelli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants