DBComposite::writeToManipulation() is never called

[lekoala]

Fixes #8800

Credits to #9182

[GuySartorelli]

Hi @lekoala, thanks for submitting this.
Can you please just briefly describe what this change is actually doing? I've not seen these constants before so it will probably help to get some perspective before I do a proper review.

Can you please also target the 4.13 branch if this is unlikely to cause regressions?

[lekoala]

hi @GuySartorelli you can check here #8800 for the long explanation
i will retarget at 4.13

[lekoala]

ok changed to 4.13

[GuySartorelli]

Touched the commit (no changes, just updated the hash) and force pushed to get CI running.

[lekoala]

not sure about the ci failing, doesn't seem realated to my changes

[GuySartorelli]

SilverStripe\ORM\Tests\DBCompositeTest::testSetFieldDynamicPropertyException
Failed asserting that exception of type "SilverStripe\ORM\Tests\InvalidArgumentException" is thrown.

That is a test this PR is adding - looks like it was intended to work with one of the php 8.2 comparability changes for CMS 5.0 so it's not a huge surprise it's failing here. You'll need to update or remove that test as appropriate.

[lekoala]

@GuySartorelli i've commented the code, i think it makes sense to restore it once merged to ss5

[GuySartorelli]

Looks good and makes sense. Thanks!