Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid cache key #10890

Closed
wants to merge 1 commit into from
Closed

fix invalid cache key #10890

wants to merge 1 commit into from

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Jul 28, 2023

fixes #10889

@lekoala lekoala mentioned this pull request Jul 28, 2023
Closed
@michalkleiner michalkleiner changed the base branch from 5 to 5.0 July 28, 2023 09:12
@michalkleiner michalkleiner changed the base branch from 5.0 to 5 July 28, 2023 09:13
@michalkleiner
Copy link
Contributor

Thanks for the contribution, @lekoala! Can you please rebase it on 5.0 and then retarget the PR? I think this can be released as a patch.

@lekoala lekoala changed the base branch from 5 to 5.0 July 28, 2023 12:12
@lekoala
Copy link
Contributor Author

lekoala commented Jul 28, 2023 •
edited
Loading

not super familiar with rebasing pr on github, but this seems like it should do it :)
EDIT: nope, it's not working^^

@lekoala lekoala changed the base branch from 5.0 to 5 July 29, 2023 06:53
@lekoala lekoala mentioned this pull request Jul 29, 2023
Merged
@lekoala
Copy link
Contributor Author

lekoala commented Jul 29, 2023

well, might as well recreate it
#10894

@michalkleiner
Copy link
Contributor

You wouldn't rebase on Github, but locally either using git cli or git gui and then force-push the branch.

@lekoala
Copy link
Contributor Author

lekoala commented Jul 29, 2023

:) that's actually more effort than create another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VersionProvider always write to cache
2 participants
@lekoala @michalkleiner