NEW add OnlyTheseMembers Inherited Permission type

[andrewandante]

To Do:

• Update batch method SQL queries
• Add tests
• Make companion PR for silverstripe-assets
• Make companion PR for silverstripe-asset-admin
• Make companion PR for silverstripe-cms
• Add proper deprecation

Issue

• ONLY_THESE_USERS is poorly named and not as useful as it should be #10817

[andrewandante]

Test failures seem unrelated to this PR:

ERROR [Emergency]: Uncaught Symfony\Component\Translation\Exception\InvalidResourceException: Error parsing YAML, invalid file "/home/runner/work/silverstripe-framework/silverstripe-framework/vendor/silverstripe/versioned-admin/lang/en.yml". Message: Duplicate key "SilverStripe\Admin\Navigator\SilverStripeNavigatorItem" detected at line 36 (near "  WONT_BE_SHOWN: 'Note: this message will not be shown to your visitors'").

[GuySartorelli]

I've rerun the tests - all green

[andrewandante]

Thanks @GuySartorelli !

Should this be merged first so that the test suites in the other repos have something to latch on to? Or would you prefer to do it all in a group?

Also, am I pointing at the right branches etc? I'm never quite confident with that stuff 😅

[GuySartorelli]

All in a group, please. This one will ultimately be merged first, but I'd like to make sure all of the PRs play nicely together first - and since they're all related it'll be easier to review them as a whole so the whole picture is in my mind when I do it.
Yup, those are the correct branches.

The only think that looks a little off at a quick glance is the todo (just remove that, and create a new CMS 6 issue for any changes that aren't behind a @deprecated phpdoc) and the deprecation message - the language for when there's a replacement is "Use [FQCN::method()] instead" (except where the new method is in the same class - then just omit the FQCN:: bit) for both the phpdoc and the deprecation notice.

See https://docs.silverstripe.org/en/5/contributing/release_process/#deprecating-api and ignore the first part about {@link <class>} which needs to be reviewed (I know the @link style is nicer for IDEs but it's harder for us to work with when automating changelogs)

[andrewandante]

Righto - I've tested all the PRs and they are working as expected for me. I've pushed all the combined branches to a demo repo here: https://github.com/andrewandante/silverstripe-only-this-user-demo/blob/main/composer.json#L11-L23 if you feel like playing around.

Last remaining thing is that when applied to assets, the list of members renders as a CheckboxSetField, because there's no React form for the ListboxField. I don't know whether you consider this a blocker or not but I don't know that I can build that form with any confidence.

[GuySartorelli]

Thank you for this work, that's a great contribution 😁
I'm not sure when I'll get to reviewing this but know that it's on my radar. The ListboxField thing is a blocker, but I'll see if I can get a react component working for it, and if not I'll be able to request some specific changes on the PR to get it across the line.

[andrewandante]

Thanks! If I get a chance I'll take another swing at it - I got reasonably close by copying the TreeDropdownMultiSelect stuff but then it needed, you know, a tree, and stopped working. The ReactStrap Select Multiple looks a bit gross, but could work in a pinch too - though it's not searchable.

[GuySartorelli]

It might help to look at TagField and AnchorSelectField which both use react-select (the same base library that TreeDropdownField uses)

[GuySartorelli]

Sorry to be a pain but can you please do the ListboxField enhancement as its own PR? It's a blocker for this work but it's really its own concern that should be reviewed and merged on its own merits (and as a bonus that might even mean someone else will get to reviewing it before I get around to looking at the rest of these)

[andrewandante]

please do the ListboxField enhancement as its own PR

Yeah no worries, I'll split it out 👍

[GuySartorelli]

This all looks okay to me. Will merge once the other PRs have finished being reviewed and are approved.
After merging, I'll rerun CI on those other PRs before merging them as well.

[GuySartorelli]

Reapproving after the latest changes