BUG: fix issue where default admin without valid email can not be saved #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
requested changes
May 12, 2023
src/Security/Member.php
Outdated
Comment on lines
777
to
778
| && $this->Email | ||
| && filter_var($this->Email, FILTER_VALIDATE_EMAIL) |
There was a problem hiding this comment.
It can just be this, filter_var will correctly handle empty strings and nulls etc.
Suggested change
| && $this->Email | |
| && filter_var($this->Email, FILTER_VALIDATE_EMAIL) | |
| && filter_var($this->Email, FILTER_VALIDATE_EMAIL) |
There was a problem hiding this comment.
Should probably use Email::is_valid_address($this->Email ?? '') instead
|
I've retargetted this at |
It is possible to have a member record without a valid email address. In this case, you can not save Member as it throws an error (email is tried being sent without a valid email address).
|
I've reset the PR to not include the extra commits and have made the recommended change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to have a default admin without a valid email. In this case, you can not save Member as it throws an error (email is tried being sent without a valid email address).
Issue