FIX Respect searchable_fields #10733
Conversation
| $searchableFields = Config::inst()->get($modelClass, 'searchable_fields'); | ||
| if (!empty($searchableFields)) { |
There was a problem hiding this comment.
Do we want to make sure here that searchable_fields is an array if set?
There was a problem hiding this comment.
Have changed to use $modelClass::singleton()->searchableFields() which returns an array
| if ($title && $list->canFilterBy($columnField)) { | ||
| return true; | ||
| $modelClass = $gridField->getModelClass(); | ||
| $searchableFields = Config::inst()->get($modelClass, 'searchable_fields'); |
There was a problem hiding this comment.
Searchable fields should be fetched by calling searchableFields() on a singleton, i.e. $modelClass::singleton()->searchableFields()
See SearchContext and GridFieldAddExistingAutocompleter as examples of where this is already done.
| foreach ($searchableFields as $searchableField) { | ||
| if ($list->canFilterBy($searchableField)) { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
canFilterBy() is fine for summary_fields() - but we can declare searchable_fields that aren't traditionally filterable here, and then tell SearchContext how to search using those fields. If a field is in searchable fields that isn't in summary fields, we should just assume it's filterable and let SearchContext sort it out.
emteknetnz
force-pushed
the
pulls/4.13/searchable
branch
from
66a2bb5 to
0f40cc3
Compare
Issue #10683
Installer run - https://github.com/emteknetnz/silverstripe-installer/actions/runs/4485413512