NEW Access dynamic data inside ViewableData #10698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Feb 21, 2023
emteknetnz
force-pushed
the
pulls/5.0/dynamic-data
branch
from
476ba6f to
b280100
Compare
src/ORM/FieldType/DBComposite.php
Outdated
| return $this; | ||
| throw new InvalidArgumentException(implode(' ', [ | ||
| "Field $field does not exist.", | ||
| 'If this was accessed via a dynamic property then use ViewableData::setDynamicData() instead.' |
There was a problem hiding this comment.
Suggested change
| 'If this was accessed via a dynamic property then use ViewableData::setDynamicData() instead.' | |
| 'If this was accessed via a dynamic property then use setDynamicData() instead.' |
We don't call ViewableData::setDynamicData('myProperty'), we just call setDynamicData on the instance of DBComposite.
There was a problem hiding this comment.
Updated. Also added unit test for the exception
emteknetnz
force-pushed
the
pulls/5.0/dynamic-data
branch
from
b280100 to
0075bf6
Compare
GuySartorelli
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10684
Makes the "dynamic properties" added for PHP 8.2 support accessible from anywhere, including classes that overload getField() etc