Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Removed #[\ReturnTypeWillChange] annotations #10639

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville marked this pull request as ready for review January 10, 2023 04:21
src/Control/HTTPRequest.php Show resolved Hide resolved
src/Control/HTTPRequest.php Outdated Show resolved Hide resolved
src/ORM/DataList.php Outdated Show resolved Hide resolved
src/ORM/DataList.php Outdated Show resolved Hide resolved
@maxime-rainville maxime-rainville force-pushed the pulls/5/no-return-type-will-change branch from 5c871d1 to c575de4 Compare January 24, 2023 22:22
@maxime-rainville
Copy link
Contributor Author

Just need some resolution on #10639 (comment) and I'll update the rest of the methods accordingly.

@maxime-rainville maxime-rainville force-pushed the pulls/5/no-return-type-will-change branch from c575de4 to e3ee1fe Compare January 26, 2023 04:19
@maxime-rainville maxime-rainville force-pushed the pulls/5/no-return-type-will-change branch from e3ee1fe to 944722f Compare January 26, 2023 05:10
@GuySartorelli GuySartorelli merged commit 4e92d25 into silverstripe:5 Jan 26, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/no-return-type-will-change branch January 26, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants