Bugfix: SSViewer check object exists before calling prop or method_exists #10589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$on
can benull
(there is no property type enforcement foritem
in the__construct()
), and when it is themethod_exists()
call will throw an error (as it expectsobject or class
for the first param).Another option could be do write it as
method_exists($on ?? '', $property ?? '')
, but I thought maybe this was a bit more descriptive.My particular project comes across this issue when we use
SSViewerCacheBlockTest::_runtemplate()
, but there might be other situations whereitem
isnull
.