Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Explicitly test with blowfish #10576

Merged
merged 1 commit into from
Nov 10, 2022
Merged

MNT Explicitly test with blowfish #10576

merged 1 commit into from
Nov 10, 2022

Conversation

emteknetnz
Copy link
Member

Issue #10574

Fix for https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/3429290339/jobs/5714714337

1) SilverStripe\Security\Tests\SecurityDefaultAdminTest::testFindAnAdministratorCreatesNewUser
Failed asserting that 'b74e431a911f29b48944a129f196028abb2b75497ad90c01668e3da397e1d4a8167e836471dedbe5d863cb0c3f00af61ca8c50fee27510b9ffb1103be4d54de4' starts with "$2y$10$".

Fails because of this commit a3c1cb0 ONLY when run on sink because of this https://github.com/silverstripe/cwp-core/blob/2/_config/encryptors.yml#L11

# Enable SHA-512 via PBKDF2 by default, for NZISM compliance
SilverStripe\Security\Security:
  password_encryption_algorithm: pbkdf2_sha512

@emteknetnz emteknetnz mentioned this pull request Nov 9, 2022
Closed
@GuySartorelli GuySartorelli merged commit e53380c into silverstripe:4.11 Nov 10, 2022
@GuySartorelli GuySartorelli deleted the pulls/4.11/use-blowfish branch November 10, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli