Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Record deprecated config #10559

Merged
merged 1 commit into from
Oct 31, 2022
Merged

NEW Record deprecated config #10559

merged 1 commit into from
Oct 31, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Oct 26, 2022 •
edited
Loading

Issue #10543

Note reliant on another PR linked the main issue - CI is green when run together https://github.com/emteknetnz/silverstripe-installer/actions/runs/3342348741

I also ended up doing some refactoring in this PR

  • Changed DeprecationTest unit tests to from expectNotice() to expectDeprecation() - came about because of the custom error handle which was required to get unit-testing working
  • Deprecated Deprecation::notice_level as it's no longer needed as we have the custom error handler
  • Changed the new protected static properties to private static marked with @internal (I didn't realize this was an option when the original PR was done)

@emteknetnz emteknetnz mentioned this pull request Oct 26, 2022
Closed
2 tasks
@emteknetnz emteknetnz force-pushed the pulls/4/deprecated-config branch 9 times, most recently from 78576d3 to d92408b Compare October 28, 2022 02:27
@emteknetnz emteknetnz marked this pull request as ready for review October 28, 2022 03:39
@emteknetnz emteknetnz force-pushed the pulls/4/deprecated-config branch from d92408b to 65cf011 Compare October 28, 2022 03:47
GuySartorelli
GuySartorelli requested changes Oct 31, 2022
View reviewed changes
src/Dev/Deprecation.php Show resolved Hide resolved
src/Dev/Deprecation.php Show resolved Hide resolved
tests/php/Dev/DeprecationTest.php Show resolved Hide resolved
tests/php/Dev/DeprecationTest.php Outdated Show resolved Hide resolved
tests/php/Dev/DeprecationTest.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/deprecated-config branch 2 times, most recently from 3173748 to 3d95771 Compare October 31, 2022 04:47
@emteknetnz emteknetnz force-pushed the pulls/4/deprecated-config branch from 3d95771 to b1dc861 Compare October 31, 2022 06:01
@GuySartorelli GuySartorelli merged commit e323fe4 into silverstripe:4 Oct 31, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/deprecated-config branch October 31, 2022 22:45
@emteknetnz emteknetnz mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @michalkleiner @GuySartorelli