FIX Handle calling Deprecation::notice() before manifests are available

[emteknetnz]

Issue silverstripe/silverstripe-assets#521

[maxime-rainville]

Not a big fan of controlling code executions based on the error message attached to an exception, but I can live with it.

I would like us to explicitly catch BadMethodCallException.

[maxime-rainville]

Seems like this would be a good place to throw a custom exception. Maybe, we can look at doing something like in CMS5/CMS6.

[maxime-rainville]

Not sure about this, but I'm assuming that every exception rethrown here, will appear to be coming from Deprecation::notice().

[emteknetnz]

I don't believe so, I think it just throws the original $e unmodified

php -r '
  class A {
    function f() {
      throw new \Exception();
    }
  }
  class B {
    function f() {
      try {
        (new A)->f();
      } catch (\Exception $e) {
        throw $e;
      }
    }
  }
  class C {
    function f() {
      try {
        (new B)->f();
      } catch (\Exception $e) {
        var_dump($e->getLine());
        var_dump($e->getTraceAsString());
      }
    }
  }
  (new C)->f();
'
int(4)
string(108) "#0 Command line code(10): A->f()
#1 Command line code(19): B->f()
#2 Command line code(26): C->f()
#3 {main}"

[emteknetnz]

@maxime-rainville Have made update, CI is green

[maxime-rainville]

LGTM.

I'm assuming since this is related to the manifest, it's something that can't really be tested.