Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member updateName extension hook #10513

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Member updateName extension hook #10513

merged 1 commit into from
Sep 27, 2022

Conversation

TheBnl
Copy link
Contributor

@TheBnl TheBnl commented Sep 26, 2022

Allow updating the member name from an extension.

When extending the Member object with fields like "Insertion" or "Initials", for example. It would be nice if we're able to change the result from the getName method so we can insert these new fields.

@TheBnl
Member updateName extension hook
f78c3ee 
Allow updating the Member name from an extension
GuySartorelli
GuySartorelli approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable - there are many reasons you might want to modify this, such as for localisation (i.e. many cultures don't put names in the same order that this method assumes)

@GuySartorelli GuySartorelli merged commit 7fd8ed1 into silverstripe:4 Sep 27, 2022
@TheBnl
Copy link
Contributor Author

TheBnl commented Sep 27, 2022

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBnl @GuySartorelli