Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Update translation to use symfony 6 #10491

Merged
merged 1 commit into from
Sep 8, 2022
Merged

API Update translation to use symfony 6 #10491

merged 1 commit into from
Sep 8, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Sep 5, 2022 •
edited
Loading

Issue #10389

@emteknetnz emteknetnz changed the title Pulls/5/symfony6 translation 2 API Update translation to use symfony 6 Sep 5, 2022
This was referenced Sep 5, 2022
Closed
Closed
@emteknetnz emteknetnz force-pushed the pulls/5/symfony6-translation-2 branch from 1c29812 to ae4abf4 Compare September 5, 2022 06:59
@GuySartorelli
Copy link
Member

@emteknetnz This needs to be rebased after the changes to the upstream PR

@emteknetnz emteknetnz force-pushed the pulls/5/symfony6-translation-2 branch 2 times, most recently from 97e5369 to 2b1aa26 Compare September 7, 2022 04:54
@emteknetnz emteknetnz marked this pull request as ready for review September 7, 2022 05:38
@emteknetnz
Copy link
Member Author

Have rebased

GuySartorelli
GuySartorelli requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has two commits - the first one should be removed, it's a holdover from the old parent PR.

composer.json Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/symfony6-translation-2 branch from 2b1aa26 to a87a657 Compare September 7, 2022 23:52
@emteknetnz
Copy link
Member Author

Updated

@GuySartorelli GuySartorelli merged commit a6a07a7 into silverstripe:5 Sep 8, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/symfony6-translation-2 branch September 8, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli