Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Set the default resources dir to "_resources" #10437

Merged
merged 2 commits into from
Aug 8, 2022
Merged

ENH Set the default resources dir to "_resources" #10437

merged 2 commits into from
Aug 8, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 3, 2022 •
edited
Loading

DO NOT SQUASH - the two commits have distinct changelog implications.

BC breaking changes

  • Removed deprecated ManifestFileFinder::RESOURCES_DIR
  • Changed default for RESOURCES_DIR const to "_resources"

Parent issue

This was referenced Aug 3, 2022
Closed
Closed
@GuySartorelli GuySartorelli marked this pull request as draft August 3, 2022 23:40
@GuySartorelli GuySartorelli changed the base branch from 4 to 5 August 4, 2022 05:10
@GuySartorelli GuySartorelli marked this pull request as ready for review August 4, 2022 05:10
@emteknetnz emteknetnz merged commit ae3a0d9 into silverstripe:5 Aug 8, 2022
@emteknetnz emteknetnz deleted the pulls/5/default-resource-dir branch August 8, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz