Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix broken unit test #10434

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

GuySartorelli
Copy link
Member

This test was introduced around the same time the general search field functionality was introduced, so the PR probably didn't include that functionality yet.

Fixes https://github.com/silverstripe/silverstripe-framework/runs/7643915707?check_suite_focus=true

SilverStripe\Forms\Tests\GridField\GridFieldFilterHeaderTest::testCustomSearchField
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Name'
+'q'

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@GuySartorelli GuySartorelli merged commit 9b1052f into silverstripe:4 Aug 3, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/fix-test branch August 3, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants