Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update github label definitions #10358

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

emteknetnz
Copy link
Member

Issue #10343

@emteknetnz emteknetnz marked this pull request as draft June 20, 2022 05:29
@emteknetnz emteknetnz mentioned this pull request Jun 20, 2022
7 tasks
| type/docs | A docs change |
| impact/critical | Website breaking issue with no workarounds. Reserved only for bugs. Bugfix's will target all supported minor release lines. |
| impact/high | Affects a major usage flow. Broken functionality with no obvious workarounds available, or an enhancement that provides a clear benefit to users |
| impact/medium | When affecting a major usage flow, for bugs there is a workaround available and for enhancements there would be a reasonable benefit to users. For a less common usage flow there is broken functionality and for enhancements there is a clear benefit to users. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any obvious distinction between "reasonable" and "clear" benefit... though I don't have an alternative wording to offer so maybe I'll just have to live with it ;p

@emteknetnz emteknetnz force-pushed the pulls/4/labels branch 2 times, most recently from 534d0b5 to 0a921b6 Compare June 20, 2022 05:59
@emteknetnz emteknetnz marked this pull request as ready for review June 26, 2022 23:11
@GuySartorelli GuySartorelli merged commit a877689 into silverstripe:4 Jun 28, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/labels branch June 28, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants