Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add extension hooks to core emails #10319

Merged
merged 1 commit into from
May 16, 2022
Merged

ENH: Add extension hooks to core emails #10319

merged 1 commit into from
May 16, 2022

Conversation

kinglozzer
Copy link
Member

@kinglozzer kinglozzer commented May 13, 2022 •
edited
Loading

A (sorta) follow up to #10313.

Extension hooks here make it possible to adjust the email contents with much more flexibility than just a single template, or even rebuild the entire email from scratch:

public function updateChangedPasswordEmail(&$email)
{
    $email = new MyCustomEmailClass();
    // ... etc
}

GuySartorelli
GuySartorelli approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dhensby dhensby merged commit 981f636 into silverstripe:4.11 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinglozzer @michalkleiner @GuySartorelli @dhensby