Fix error when posix_getpwuid returns false
#10299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The posix_getpwuid function can return false if it fails (see [docs](https://www.php.net/manual/en/function.posix-getpwuid.php#:~:text=The%20function%20returns%20false%20on%20failure.)).
dhensby
approved these changes
May 4, 2022
GuySartorelli
approved these changes
May 5, 2022
|
@edwilde I've retargetted this at the new |
|
Sweet, thanks @GuySartorelli 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The posix_getpwuid function can return
falseif it fails (see docs).If this happens, it results in a notice output in the CMS/front-end and broken functionality.
Notice: Trying to access array offset on value of type bool in ***/vendor/silverstripe/framework/src/Core/TempFolder.php on line 42Since there is a cascade in the
getTempFolderUsername()function, I would assume it is safe to have$userset tofalseif it fails and to continue to look for another method to populate it successfully.Observed in PHP 7.4.28 + PHP 7.4.29, macOS 12.3.1, M1 pro