ENH Fix deprecation issues for PHP 8.1 compatibility #10273

emteknetnz · 2022-04-05T01:48:00Z

Issue #10250

Manually fixing various issues related to php8.1

auto_detect_line_endings deprecated

The ini setting auto_detect_line_endings is deprecated as of php 8.1

This is set in a couple of places for csv handling and is blocks php 8.1 compatibility

The option is no longer required

https://php.watch/versions/8.1/auto_detect_line_endings-ini-deprecated

strftime deprecated

Replaced with date()

https://php.watch/versions/8.1/strftime-gmstrftime-deprecated

Passing null to parameter deprecated

A few instances of null being used instead of '' for a blank parameter

https://php.watch/versions/8.1/internal-func-non-nullable-null-deprecation

Note: the bulk of this conversion work was done automatically, links to PRs are on the parent issue

Casting ctype_digit param to string

The param type is mixed, though from php 8.1 passing a non-string param is deprecated

https://www.php.net/manual/en/function.ctype-digit.php

Calling static methods on traits

https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.core.static-trait

maxime-rainville

I prefer the $class::has_extension(MyExtension::class) syntax to the ViewableData::has_extension($class, MyExtension::class).

Mostly, I don't like that in theory that ViewableData could be substituted with any other class that uses the Extensible trait. And the one parameter syntax is a bit nicer. Admittedly, that's a personal taste.

I'm not dead set against ViewableData::has_extension($class, MyExtension::class) and I'm happy to use that if people think it make more sense.

Mostly, I just want us to pick one option and stick with it everywhere.

maxime-rainville · 2022-04-06T06:51:52Z

docs/en/02_Developer_Guides/19_GraphQL/05_plugins/03_writing_a_complex_plugin.md

@@ -56,7 +56,7 @@ class GeocodableDataObject implements ModelTypePlugin
        );

        // only apply the plugin to geocodable DataObjects
-        if (!Extensible::has_extension($class, Geocodable::class)) {
+        if (!ViewableData::has_extension($class, Geocodable::class)) {


I would suggest using this syntax instead because ViewableData does not inherently have anything to do with the current context. But in the grander scheme, it doesn't really matter.

Suggested change

if (!ViewableData::has_extension($class, Geocodable::class)) {

if (!$class::has_extension(Geocodable::class)) {

We don't know ahead of time if $class has the Extensible trait, so we'd need something like this

method_exists($class, 'has_extension') && call_user_func("$class::has_extension", $class, Geocodable::class)

Which is very verbose. Therefore I think it's better to simply use

ViewableData::has_extension($class, Geocodable::class)

That's fair point.

maxime-rainville · 2022-04-06T06:52:27Z

docs/en/02_Developer_Guides/19_GraphQL/05_plugins/03_writing_a_complex_plugin.md

@@ -85,7 +85,7 @@ class GeocodableQuery implements ModelQueryPlugin
    {
        $class = $query->getModel()->getSourceClass();
        // Only apply to geocodable objects
-        if (!Extensible::has_extension($class, Geocodable::class)) {
+        if (!ViewableData::has_extension($class, Geocodable::class)) {


Suggested change

if (!ViewableData::has_extension($class, Geocodable::class)) {

if (!$class::has_extension(Geocodable::class)) {

maxime-rainville · 2022-04-06T06:52:49Z

docs/en/02_Developer_Guides/19_GraphQL/05_plugins/03_writing_a_complex_plugin.md

@@ -177,7 +177,7 @@ public function apply(ModelQuery $query, Schema $schema, array $config = []): vo
 {
    $class = $query->getModel()->getSourceClass();
    // Only apply to geocodable objects
-    if (!Extensible::has_extension($class, Geocodable::class)) {
+    if (!ViewableData::has_extension($class, Geocodable::class)) {


Suggested change

if (!ViewableData::has_extension($class, Geocodable::class)) {

if (!$class::has_extension(Geocodable::class)) {

maxime-rainville · 2022-04-06T06:53:34Z

src/Core/ClassInfo.php

@@ -597,7 +598,7 @@ public static function classesWithExtension(

        // only keep classes with the Extension applied
        $classes = array_filter($classes, function ($class) use ($extensionClass) {
-            return Extensible::has_extension($class, $extensionClass);
+            return ViewableData::has_extension($class, $extensionClass);


Suggested change

return ViewableData::has_extension($class, $extensionClass);

return $class::has_extension($extensionClass);

maxime-rainville · 2022-04-06T06:54:30Z

src/ORM/Hierarchy/Hierarchy.php

@@ -17,6 +16,7 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use Exception;
+use SilverStripe\View\ViewableData;


Suggested change

use SilverStripe\View\ViewableData;

maxime-rainville · 2022-04-06T06:54:50Z

src/ORM/Hierarchy/Hierarchy.php

@@ -418,7 +418,7 @@ private function getHierarchyBaseClass(): string
    {
        $ancestry = ClassInfo::ancestry($this->owner);
        $ancestorClass = array_shift($ancestry);
-        while ($ancestorClass && !Extensible::has_extension($ancestorClass, self::class)) {
+        while ($ancestorClass && !ViewableData::has_extension($ancestorClass, self::class)) {


Suggested change

while ($ancestorClass && !ViewableData::has_extension($ancestorClass, self::class)) {

while ($ancestorClass && !$ancestorClass::has_extension(self::class)) {

maxime-rainville

Objection has been withdrawn.

This was referenced Apr 5, 2022

Do not set deprecated auto_detect_line_endings #10272

Closed

PHP 8.1 compatibility #10250

Closed

emteknetnz marked this pull request as draft April 5, 2022 02:09

emteknetnz force-pushed the pulls/4/remove-ini-setting branch from b3fda33 to 2afac0a Compare April 5, 2022 02:48

emteknetnz changed the title ~~ENH Do not set deprecated auto_detect_line_endings~~ ENH Fix deprecation issues for php 8.1 compatibility Apr 5, 2022

emteknetnz changed the title ~~ENH Fix deprecation issues for php 8.1 compatibility~~ ENH Fix deprecation issues for PHP 8.1 compatibility Apr 5, 2022

emteknetnz force-pushed the pulls/4/remove-ini-setting branch 4 times, most recently from 71b0220 to 7c8b9a6 Compare April 5, 2022 09:25

emteknetnz marked this pull request as ready for review April 5, 2022 21:18

ENH Fix deprecation issues for PHP 8.1 compatibility

814c5b2

emteknetnz force-pushed the pulls/4/remove-ini-setting branch from 7c8b9a6 to 814c5b2 Compare April 5, 2022 23:34

maxime-rainville requested changes Apr 6, 2022

View reviewed changes

maxime-rainville approved these changes Apr 7, 2022

View reviewed changes

maxime-rainville merged commit 3e5a74c into silverstripe:4 Apr 7, 2022

maxime-rainville deleted the pulls/4/remove-ini-setting branch April 7, 2022 01:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH Fix deprecation issues for PHP 8.1 compatibility #10273

ENH Fix deprecation issues for PHP 8.1 compatibility #10273

emteknetnz commented Apr 5, 2022 •

edited

Loading

maxime-rainville left a comment

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022 •

edited

Loading

maxime-rainville Apr 7, 2022

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022

maxime-rainville Apr 6, 2022

emteknetnz Apr 6, 2022

maxime-rainville left a comment

	if (!ViewableData::has_extension($class, Geocodable::class)) {
	if (!$class::has_extension(Geocodable::class)) {

	return ViewableData::has_extension($class, $extensionClass);
	return $class::has_extension($extensionClass);

	while ($ancestorClass && !ViewableData::has_extension($ancestorClass, self::class)) {
	while ($ancestorClass && !$ancestorClass::has_extension(self::class)) {

ENH Fix deprecation issues for PHP 8.1 compatibility #10273

ENH Fix deprecation issues for PHP 8.1 compatibility #10273

Conversation

emteknetnz commented Apr 5, 2022 • edited Loading

auto_detect_line_endings deprecated

strftime deprecated

Passing null to parameter deprecated

Casting ctype_digit param to string

Calling static methods on traits

maxime-rainville left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emteknetnz Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxime-rainville left a comment

Choose a reason for hiding this comment

emteknetnz commented Apr 5, 2022 •

edited

Loading

emteknetnz Apr 6, 2022 •

edited

Loading