Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Extension hook for email default from #10251

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Mar 7, 2022

Follow up for #10217

@GuySartorelli
Copy link
Member

Would it be worth documenting this in docs/en/02_Developer_Guides/10_Email/index.md?

@emteknetnz
Copy link
Member Author

Unit test failing is fixed here (4.10) instead - #10252

@emteknetnz
Copy link
Member Author

emteknetnz commented Mar 8, 2022

Would it be worth documenting this

I don't think so, what you really should be doing is setting the email via the SilverStripe\Control\Email::admin_email config, and this is already documented

There's a lot of undocumented extension hooks through the codebase, so not documenting this is consistent

Edit: actually I take this back - original reason for putting this in was for hosting migrations that included subsites. I'll document something

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the unit test issue being addressed separately in a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants