ENH PHP 8.1 compatibility #10222
ENH PHP 8.1 compatibility #10222
Conversation
emteknetnz
force-pushed
the
pulls/4/php81
branch
5 times, most recently
from
9093da8 to
9f72453
Compare
emteknetnz
force-pushed
the
pulls/4/php81
branch
from
9f72453 to
539ddee
Compare
emteknetnz
force-pushed
the
pulls/4/php81
branch
9 times, most recently
from
fb02efc to
2f49964
Compare
emteknetnz
force-pushed
the
pulls/4/php81
branch
from
2f49964 to
646ca4f
Compare
emteknetnz
force-pushed
the
pulls/4/php81
branch
from
646ca4f to
511b3bb
Compare
|
The error in the travis build is unrelated and is fixed by silverstripe/silverstripe-travis-shared#36 |
There was a problem hiding this comment.
For posterity: See discussion in silverstripe/silverstripe-admin#1294 about the general approach. tl;dr:
the purposes of this PR is to avoid passing null (specifically null) from built-in functions that as of php 8.1 will throw deprecation warnings if null is passed in. The approach is necessarily heavy-handed, and while there are many situations where it isn't needed, it would be prohibitively laborious to find all of those situations by hand.
Additionally, where #[\ReturnTypeWillChange] has been used, this is to avoid a breaking change in our API where php8.1 now enforces a given return type.
Looks good to me
Issue #10250