-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various typos with codespell #10177
Conversation
Thanks @lerni, nice job. Been thinking of going through the codebase of the core modules at some point, too. I've started reviewing the changes, got to 30 files so far, the majority is looking good. Should get through the rest today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, went over all the changes.
@lerni the change in GridFieldSortableHeaderTest
needs further work, the PR only renames the initial variable when created, but not when used. I've added two change suggestions, but you'd need to go through the class and update all the occurrences.
Three minor things to confirm with @maxime-rainville or @emteknetnz:
|
Yup agree with what @michalkleiner has said re 1. and 2. 3. is fine with the rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lerni, appreciate the contribution.
@michalkleiner thank you for reviewing it so fast: I'm impressed! 💯 ❤️ May this motivates me checking others like CMS with codespell as well 😉 |
Mostly fixes typos in strings, docs & comments
Also some variablenames are renamed:
famework/src/Core/CoreKernel.php
$environment
vendor/silverstripe/framework/src/ORM/DataObject.php
$identifier
vendor/silverstripe/framework/tests/php/Forms/GridField/GridFieldSortableHeaderTest.php
$component
Had a play with codespell - this PR is the outcome. Hopefully someone is willing to review - it's a lot.