FIX Allow custom SELECT to be used for sorting in DataQuery::column() #10173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @GuySartorelli. Is there any chance you could add a test for this fix? |
michalkleiner
changed the title
|
@michalkleiner Test added. |
|
Thanks @GuySartorelli, wonderful! Could you please squash the commits into one saying "FIX Allow custom SELECT to be used for sorting in DataQuery::column()" and then we're good to merge. |
michalkleiner
approved these changes
Dec 13, 2021
If a custom select clause (using special features such as `CASE`) is used, and it was added using `SQLSelect::selectField`, the custom select clause should be retained when calling DataQuery::column().
GuySartorelli
force-pushed
the
patch-2
branch
from
303c17d to
0b0c137
Compare
|
@michalkleiner Commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom select clause (using special features such as
CASE) is used, and it was added usingSQLSelect::selectField, the custom select clause should be retained when calling DataQuery::column().I know that using
SQLSelect::addOrderByto add the select clause is handled correctly, but that's because it uses a special alias. If I want to use a specific alias, I can't rely on that.