ENH Speed up DataObject::get_by_id by checking if there is an ID at all

[sunnysideup]

There is no point in preparing a database call when the ID value is lower than one.

[michalkleiner]

Thanks @sunnysideup, please fix the lint errors

3492 | ERROR | [x] Expected 1 space(s) after IF keyword; 0 found
3493 | ERROR | [x] Whitespace found at end of line

[sunnysideup]

@michalkleiner - what would be really awesome is to have an automated linter go through this and clean it all up so we can focus on the important stuff. I am developing: https://github.com/sunnysideup/silverstripe-easy-coding-standards for this.

[michalkleiner]

Thanks @sunnysideup. I'm ready to merge this, can you please squash the commits into one and force push the update? Thanks!

[sunnysideup]

done

…

On Sat, 15 Jan 2022 at 10:31, Michal Kleiner ***@***.***> wrote: ***@***.**** approved this pull request. Thanks @sunnysideup <https://github.com/sunnysideup>. I'm ready to merge this, can you please squash the commits into one and force push the update? Thanks! — Reply to this email directly, view it on GitHub <#10163 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABIZ4RNUJNIFD3FVE7RUMTUWCIZLANCNFSM5JFO3UEA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- *NOTE: to improve our service all customer requests can now be sent to ***@***.*** ***@***.***>* { Nicolaas Thiemen Francken www.sunnysideup.co.nz +64 (0) 221 697577 }