Fix broken tests #10136
Merged
Fix broken tests #10136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis won’t run on this PR... ugh Edit: there we go |
emteknetnz
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was missing from #10113. The diff on that PR shows at as being added to lines 1115 - 1123, but it was actually added to 2437 - 2445. I think that’s probably because the PHPUnit 9 changes (which effectively duplicate the
SapphireTestclass) were merged after that PR was open, and for some reason Github’s UI was showing the changes in the wrong place.Either way, it needs to be added to both copies of
SapphireTest.