ENH Search all summary fields and split words #10055
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC, don't merge
Issue #9356
In both cases it does a
WHERE .. OR
on thingsI think that 1) is good, I'm not entirely sure if 2) is entirely good because it won't put the most relevant search results at the top e.g. if searching on 3 words and it matches all 3, it won't necessarily put that as the top search result. Weight is the same something that partially matched on a single word. This might be considered OK though.
I'd prefer we don't attempt to go too far with this at this stage, we're not trying to build a fully fledged search engine :-) I think what we have here is a significant improvement.
Should probably point to the
4
branch because it's a behaviour changeSome front end changes are probably required within the admin module to tidy up the UX when using the advanced filter, possibly disable the 'summary_fields' field and remove the placeholder text