Form::defaultAction() doesn’t work if actions contains CompositeFields

[kinglozzer]

Affected Version

4.0 - 4.8

Description

If the form “actions” FieldList contains a CompositeField as the first child, Form::defaultActions() will cause an error if the user submits the form without clicking an action button.

silverstripe-framework/src/Forms/Form.php

Line 1705 in ecd58cb

return $this->actions->first();

This will return the CompositeField, which then causes an error on submission when this code is reached, as actionName() doesn’t exist in CompositeField:

silverstripe-framework/src/Forms/FormRequestHandler.php

Line 185 in ecd58cb

$funcName = $defaultAction->actionName();

Steps to Reproduce

Wrap your form action(s) in a CompositeField, e.g:

$actions = FieldList::create(
    CompositeField::create(
        FormAction::create('doMyForm', 'Submit')
    )->addExtraClass('some-css-classes')
);

return Form::create($this, __FUNCTION__, $fields, $actions, $validator);

Then submit the form without clicking the action button, e.g. with JS console:

document.querySelector('#Form_MyForm').submit();

You should see the following error:

Uncaught BadMethodCallException: Object->__call(): the method 'actionName' does not exist on 'SilverStripe\Forms\CompositeField'

[GuySartorelli]

PR merged and tagged as 4.13.2