Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in tests/php/Forms/CheckboxSetFieldMultiEnumTest.php #10689

Closed
kinglozzer opened this issue Feb 13, 2023 · 3 comments
Closed

Typo in tests/php/Forms/CheckboxSetFieldMultiEnumTest.php #10689

kinglozzer opened this issue Feb 13, 2023 · 3 comments

Comments

@kinglozzer
Copy link
Member

https://github.com/silverstripe/silverstripe-framework/blob/5.0.0-beta1/tests/php/Forms/CheckboxSetFieldMultiEnumTest.php#L14

Causes a warning when running tests:

Warning: Test case class not matching filename is deprecated
in ./silverstripe-framework/tests/php/Forms/CheckboxSetFieldMultiEnumTest.php
Class name was 'CheckboxSetFieldMulitEnumTest', expected 'CheckboxSetFieldMultiEnumTest'

Could we just rename the class before we tag 5.0.0 stable?

@GuySartorelli
Copy link
Member

@maxime-rainville you'd need to approve that as it's an API breaking change post beta

@GuySartorelli
Copy link
Member

Actually nevermind, I just noticed it's a test class. We can do that any time. If it's in CMS 4 we can do it there too.

@maxime-rainville
Copy link
Contributor

Yeah ... that's been bugging me. Every time I run test locally, I keep thinking "I should really just rename this class and be done with it".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants