Merge pull request #10020 from GuySartorelli/patch-4

FIX Remove limits in removeAll method
silverstripe · Jan 14, 2022 · dee0b1f · dee0b1f
2 parents 30325f6 + 5699db3
commit dee0b1f
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/ORM/ManyManyList.php b/src/ORM/ManyManyList.php
@@ -404,6 +404,7 @@ public function removeAll()
         unset($from[$this->joinTable]);
         $selectQuery->setFrom($from);
         $selectQuery->setOrderBy(); // ORDER BY in subselects breaks MS SQL Server and is not necessary here
+        $selectQuery->setLimit(null); // LIMIT in subselects breaks MariaDB (https://mariadb.com/kb/en/subquery-limitations/#limit) and is not necessary here
         $selectQuery->setDistinct(false);
 
         // Use a sub-query as SQLite does not support setting delete targets in