Merge pull request #11158 from lekoala/patch-47

FIX Generate salt if needed
silverstripe · Mar 4, 2024 · dba8734 · dba8734
2 parents d33332c + eb4ef62
commit dba8734
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/Security/Member.php b/src/Security/Member.php
@@ -520,13 +520,11 @@ public function encryptWithUserSettings($string)
 
         // If the algorithm or salt is not available, it means we are operating
         // on legacy account with unhashed password. Do not hash the string.
-        if (!$this->PasswordEncryption) {
+        if (!$this->PasswordEncryption || !$this->Salt) {
             return $string;
         }
 
-        // We assume we have PasswordEncryption and Salt available here.
         $e = PasswordEncryptor::create_for_algorithm($this->PasswordEncryption);
-
         return $e->encrypt($string, $this->Salt);
     }