Merge pull request #10307 from silverstripe-terraformers/feature/remo…

…val-all-enhancement ENH: RemoveAll() memory performance enhancement.
silverstripe · May 13, 2022 · c0ff638 · c0ff638
2 parents 995e5dc + b864c11
commit c0ff638
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/ORM/DataList.php b/src/ORM/DataList.php
@@ -1174,7 +1174,7 @@ public function shuffle()
      */
     public function removeAll()
     {
-        foreach ($this as $item) {
+        foreach ($this->getGenerator() as $item) {
             $this->remove($item);
         }
         return $this;

diff --git a/tests/php/ORM/DataListTest.php b/tests/php/ORM/DataListTest.php
@@ -458,6 +458,17 @@ public function testRemoveByID()
         $this->assertNull($list->byID($id));
     }
 
+    /**
+     * Test DataList->removeAll()
+     */
+    public function testRemoveAll()
+    {
+        $list = Team::get();
+        $this->assertGreaterThan(0, $list->count());
+        $list->removeAll();
+        $this->assertCount(0, $list);
+    }
+
     /**
      * Test DataList->canSortBy()
      */