Revert "Use field editorconfig when sanitising content" (#11180)

This reverts commit e5eb98c.
silverstripe · Mar 19, 2024 · 6ede031 · 6ede031
1 parent c8c2695
commit 6ede031
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 40 deletions.
diff --git a/src/Forms/HTMLEditor/HTMLEditorField.php b/src/Forms/HTMLEditor/HTMLEditorField.php
@@ -145,8 +145,7 @@ public function saveInto(DataObjectInterface $record)
         // Sanitise if requested
         $htmlValue = HTMLValue::create($this->Value());
         if (HTMLEditorField::config()->sanitise_server_side) {
-            $config = $this->getEditorConfig();
-            $santiser = HTMLEditorSanitiser::create($config);
+            $santiser = HTMLEditorSanitiser::create(HTMLEditorConfig::get_active());
             $santiser->sanitise($htmlValue);
         }
 

diff --git a/tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php b/tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php
@@ -11,7 +11,6 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\Forms\HTMLEditor\HTMLEditorConfig;
 use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
 use SilverStripe\Forms\HTMLEditor\TinyMCEConfig;
 use SilverStripe\Forms\HTMLReadonlyField;
@@ -230,41 +229,4 @@ public function testValueEntities()
             $field->obj('ValueEntities')->forTemplate()
         );
     }
-
-    public function testFieldConfigSanitization()
-    {
-        $obj = TestObject::create();
-        $editor = HTMLEditorField::create('Content');
-        $defaultValidElements = [
-            '@[id|class|style|title|data*]',
-            'a[id|rel|dir|tabindex|accesskey|type|name|href|target|title|class]',
-            '-strong/-b[class]',
-            '-em/-i[class]',
-            '-ol[class]',
-            '#p[id|dir|class|align|style]',
-            '-li[class]',
-            'br',
-            '-span[class|align|style]',
-            '-ul[class]',
-            '-h3[id|dir|class|align|style]',
-            '-h2[id|dir|class|align|style]',
-            'hr[class]',
-        ];
-        $restrictedConfig = HTMLEditorConfig::get('restricted');
-        $restrictedConfig->setOption('valid_elements', implode(',', $defaultValidElements));
-        $editor->setEditorConfig($restrictedConfig);
-
-        $expectedHtmlString = '<p>standard text</p>Header';
-        $htmlValue = '<p>standard text</p><table><tbody><tr><th></th></tr><tr><td>Header</td></tr></tbody><tbody></tbody></table>';
-        $editor->setValue($htmlValue);
-        $editor->saveInto($obj);
-        $this->assertEquals($expectedHtmlString, $obj->Content, 'Table is not removed');
-
-        $defaultConfig = HTMLEditorConfig::get('default');
-        $editor->setEditorConfig($defaultConfig);
-
-        $editor->setValue($htmlValue);
-        $editor->saveInto($obj);
-        $this->assertEquals($htmlValue, $obj->Content, 'Table is removed');
-    }
 }