Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Block schema is now extensible, getBlockSchema marked as internal #313

Conversation

robbieaverill
Copy link
Contributor

This change ensures that the block schema can be modified by extensions, and that overloaded methods will run before the extension does.

Copy link
Contributor

@ScopeyNZ ScopeyNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Can you add the relevant change to ElementContent? - Currently it overloads getBlockSchema but we should follow our own advice and overload the provideBlockSchema method.

@robbieaverill robbieaverill force-pushed the pulls/4.0/extensible-block-schema branch from 6141b42 to 0fb157d Compare August 12, 2018 22:53
@robbieaverill
Copy link
Contributor Author

Done, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants