NEW Implementing edit link on inline blocks and updating styling #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (!ID) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="element-editor__element"> | ||
| <a className="element-editor__element" href={link} title={linkTitle}> |
There was a problem hiding this comment.
Hmm, I don't know if I like this. Can you nest the anchor inside the div instead?
There was a problem hiding this comment.
I will have to remove all padding from the div and add it to the anchor - which is what that class did - so it made sense to move the class to the anchor tag, then the div was kind of pointless. Not really sure what a better solution to that would be?
robbieaverill
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each block is now an anchor tag that links to the GridFieldDetailForm for the element. I updated the hover styling in this PR too.