Add First, Last, Pos, TotalItems and EvenOdd helpers #282
Conversation
src/Models/BaseElement.php
Outdated
| */ | ||
| public function isFirstElement() | ||
| { | ||
| return !($this->Parent()->Elements()->filter('Sort:LessThan', $this->Sort)->exists()); |
There was a problem hiding this comment.
What do you reckon about $this->Parent()->Elements()->first() === $this?
There was a problem hiding this comment.
Would $this be robust enough? I'm just thinking of objects perhaps changing at runtime with something like fluent etc..
Perhaps $this->Parent()->Elements()->first()->ID === $this->ID. ID is all that matters right?
There was a problem hiding this comment.
Yeah give that a go. Your tests should be good enough to try it out =D
|
Related: #211 |
|
@robbieaverill What to you think like #211 should we do something at the ElementArea level or leave it as functions on |
|
@wilr I'm happy to follow your judgement =) they sound like useful methods either way |
wilr
changed the title
|
Ok my judgement is consistently probably out weighs risk since the behaviour for all the options is going to be the same unless you start to do funky things like building your own Updated the code, tests and docs. Changed branch to 3 |
src/Models/BaseElement.php
Outdated
| } | ||
|
|
||
| /** | ||
| * @return boolean |
There was a problem hiding this comment.
Minor: should be int
src/Models/BaseElement.php
Outdated
| /** | ||
| * Returns the position of the current element. | ||
| * | ||
| * @return boolean |
src/Models/BaseElement.php
Outdated
| } | ||
|
|
||
| /** | ||
| * @return boolean |
| if ($this->hasExtension(Versioned::class)) { | ||
| $records = Versioned::get_by_stage(BaseElement::class, Versioned::DRAFT); | ||
| } else { | ||
| $records = BaseElement::get()->max('Sort'); |
There was a problem hiding this comment.
Sorry for the late review but it appears this is a bug?
There was a problem hiding this comment.
@ScopeyNZ What seems to be the bug? I added this in as it was skipping draft version numbers and it was also using the global max rather than the local max.
There was a problem hiding this comment.
$records = ...->max('Sort') should return an int, but is treated like an object on the next line?
There was a problem hiding this comment.
Ah yep, but only if versioned had been removed with is rare. I'll submit a fix to the 3 branch.
Thanks
When in an Element template the expected $First, $Last helpers aren't there so this replaces them with something.