API Remove deprecated code #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Jan 16, 2023
tests/GraphQL/FakeResolveInfo.php
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace DNADesign\Elemental\Tests\GraphQL; | |||
|
|
|||
| use ArrayObject; | |||
| use GraphQL\Language\AST\OperationDefinitionNode; | |||
There was a problem hiding this comment.
use ArrayObject;
use GraphQL\Language\AST\OperationDefinitionNode;
Required types of parameters in ResolveInfo constructor : https://github.com/webonyx/graphql-php/blob/master/src/Type/Definition/ResolveInfo.php#L123-L132
|
Broken Behat tests are related to the issue https://github.com/silverstripeltd/product-issues/issues/655 |
6 tasks
emteknetnz
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Merge conflict on FakeResolveInfo
Please rebase on 5 and use the version in this commit - 43dde3a#diff-445b2b99e2d2c31b3d1a34241221643396fd9134c296395559728b3f67ade3a0
sabina-talipova
force-pushed
the
pulls/5/remove-deprecations
branch
from
705e51e to
c73d578
Compare
|
DONE |
emteknetnz
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue