Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX HTML showing in inline preview #42

Merged
merged 1 commit into from
Jul 11, 2023
Merged

FIX HTML showing in inline preview #42

merged 1 commit into from
Jul 11, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Jul 10, 2023
Closed
@sabina-talipova sabina-talipova force-pushed the pulls/3.0/fix-html-in-block branch 4 times, most recently from 4129d16 to 49cb53a Compare July 10, 2023 02:46
GuySartorelli
GuySartorelli requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just one small change.

src/Block/FileBlock.php Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/3.0/fix-html-in-block branch 3 times, most recently from 3512938 to dada51b Compare July 11, 2023 01:02
GuySartorelli
GuySartorelli requested changes Jul 11, 2023
View reviewed changes
src/Block/FileBlock.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/3.0/fix-html-in-block branch from dada51b to 2f06274 Compare July 11, 2023 01:41
@sabina-talipova
Copy link
Contributor Author

Updated

GuySartorelli
GuySartorelli approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@GuySartorelli GuySartorelli merged commit e08ab3f into silverstripe:3.0 Jul 11, 2023
@GuySartorelli GuySartorelli deleted the pulls/3.0/fix-html-in-block branch July 11, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli