MNT Fix scss lint warnings (#148)

silverstripe · Jun 11, 2024 · 0e28ce1 · 0e28ce1
1 parent 363f83f
commit 0e28ce1
Show file tree

Hide file tree

Showing 6 changed files with 451 additions and 821 deletions.
diff --git a/.stylelintignore b/.stylelintignore
diff --git a/client/dist/styles/bundle.css b/client/dist/styles/bundle.css
diff --git a/client/src/components/BannerBlock/Frontend.scss b/client/src/components/BannerBlock/Frontend.scss
@@ -29,8 +29,8 @@
 
 .banner-element__call-to-action {
   padding: 10px;
-  background: red;
-  color: white !important;
+  background: #f00;
+  color: #fff !important;
   display: inline-block;
   text-decoration: none;
   margin-bottom: 10px;

diff --git a/client/src/components/BlockLinkField/BlockLinkField.scss b/client/src/components/BlockLinkField/BlockLinkField.scss
@@ -8,9 +8,9 @@
   }
 }
 
-.block-link-field__icon::before {
+.block-link-field__icon:before {
   content: "2"; // font-icon-link
-  font-family: silverstripe;
+  font-family: "silverstripe";
   font-size: $font-size-lg * 1.2;
   left: $btn-icon-spacing;
   margin-right: $btn-icon-spacing * 3;

diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
     "watch": "yarn && NODE_ENV=development webpack --watch --progress",
     "css": "WEBPACK_CHILD=css npm run build",
     "test": "jest",
-    "lint": "eslint client/src; stylelint **/client/src/**/*.scss",
+    "lint": "eslint client/src; stylelint client/src",
     "lint-js-fix": "eslint client/src --fix"
   },
   "repository": {
@@ -36,7 +36,7 @@
     "reactstrap": "^8.9.0"
   },
   "devDependencies": {
-    "@silverstripe/eslint-config": "^1.2.1",
+    "@silverstripe/eslint-config": "^1.3.0",
     "@silverstripe/webpack-config": "^2.1.0",
     "@testing-library/react": "^14.0.0",
     "babel-jest": "^29.2.2",