Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Loosen config order to allow "after: '*'" in framework #2793

Merged
merged 1 commit into from
Oct 19, 2022
Merged

FIX Loosen config order to allow "after: '*'" in framework #2793

merged 1 commit into from
Oct 19, 2022

Conversation

GuySartorelli
Copy link
Member

There's only one block of config that this affects, which is the coreconfig block inside framework. Having After: 'framework/*' is stopping us from using After: '*' in framework.

@emteknetnz emteknetnz merged commit af1a482 into silverstripe:5 Oct 19, 2022
@emteknetnz emteknetnz deleted the pulls/5/config-order branch October 19, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz