Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate BatchActionParameters #2628

Closed
wants to merge 1 commit into from
Closed

Deprecate BatchActionParameters #2628

wants to merge 1 commit into from

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Jan 5, 2021

Resolves #1350

@bergice bergice changed the base branch from 4.7 to 4 January 5, 2021 23:34
@bergice bergice linked an issue Jan 5, 2021 that may be closed by this pull request
CMSBatchAction::getParameterFields() never seems to get called/used #1350
Closed
6 tasks
@bergice bergice mentioned this pull request Jan 5, 2021
Closed
6 tasks
@chillu
Copy link
Member

chillu commented Jan 18, 2021

Sorry for splitting hairs, but can you please mark this as @deprecated 4.8.0:5.0.0 instead? We've already released 4.7.0, and this is (correctly) targeted at the 4 branch (so deprecating in the next minor release). See https://docs.silverstripe.org/en/4/contributing/release_process/#deprecation

@GuySartorelli
Copy link
Member

Batch actions parameters are now used per #2746

@GuySartorelli GuySartorelli deleted the pulls/4.7/deprecate-BatchActionParameters branch August 2, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMSBatchAction::getParameterFields() never seems to get called/used
3 participants
@bergice @chillu @GuySartorelli