Merge pull request #3032 from creative-commoners/pulls/6/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 9ace9be · 9ace9be
2 parents 86c0708 + bbf24f8
commit 9ace9be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/code/Model/SiteTreeLinkTracking.php b/code/Model/SiteTreeLinkTracking.php
@@ -79,7 +79,7 @@ public function getParser()
      * @param SiteTreeLinkTracking_Parser $parser
      * @return $this
      */
-    public function setParser(SiteTreeLinkTracking_Parser $parser = null)
+    public function setParser(?SiteTreeLinkTracking_Parser $parser = null)
     {
         $this->parser = $parser;
         return $this;

diff --git a/code/Search/SearchForm.php b/code/Search/SearchForm.php
@@ -52,10 +52,10 @@ class SearchForm extends Form
      * @param FieldList $actions Optional, defaults to a single field named "Go".
      */
     public function __construct(
-        RequestHandler $controller = null,
+        ?RequestHandler $controller = null,
         $name = 'SearchForm',
-        FieldList $fields = null,
-        FieldList $actions = null
+        ?FieldList $fields = null,
+        ?FieldList $actions = null
     ) {
         if (!$fields) {
             $fields = new FieldList(