ENH Replace ADMIN permissions with less permissions in Behat test #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
sabina-talipova
force-pushed
the
pulls/1/review-behat-tests
branch
2 times, most recently
from
8faafd2 to
a1fe212
Compare
GuySartorelli
requested changes
Sep 8, 2022
| @@ -6,7 +6,8 @@ Feature: Manage campaigns | |||
|
|
|||
| Background: | |||
| Given a "campaign" "Test Campaign" with "Description"="this is a test" | |||
| And I am logged in with "ADMIN" permissions | |||
| And the "group" "EDITOR" has permissions "Access to 'Pages' section" and "Access to 'Campaigns' section" and "Access to 'Files' section" and "FILE_EDIT_ALL" | |||
There was a problem hiding this comment.
Are all of these permissions required for all of these scenarios? Seems likely that some of these can be split out to use less permissions.
There was a problem hiding this comment.
I created additional user with only "Campaign section" permissions.
But for the last Scenario: Publishing a campaign publishes associated assets I left "EDITOR" with permission as is.
sabina-talipova
force-pushed
the
pulls/1/review-behat-tests
branch
from
a1fe212 to
6c583f7
Compare
sabina-talipova
force-pushed
the
pulls/1/review-behat-tests
branch
from
6c583f7 to
4d0f492
Compare
GuySartorelli
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace user with "Admin" permissions to user with "Editor" permissions.
Parent issue