DEP Require symfony ^6.1 and friends-of-behat/mink-extension fork #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
emteknetnz
force-pushed
the
pulls/5/symfony6
branch
from
e2d3781 to
626604f
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/5/symfony6
branch
from
626604f to
e7e99c2
Compare
|
@emteknetnz You've mentioned a PR in the description that doesn't seem to exist? |
|
Sorry originally I forked behat/MinkExtension to silverstripe/MinkExtension so that we could get symfony 6 support as the upstream module lacks it. I later found out later that another maintained fork friends-of-behat/MinkExtension has symfony 6 support |
GuySartorelli
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10389
Requires that https://github.com/silverstripe/MinkExtension/pull/1 is merged first, has been given a 2.3.2 tag and packagist for silverstripe/mink-extension is functioning^ Has been superseded by the friends-of-behat/mink-extension fork