Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Don't use keyword "self" #622

Merged

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-assets/actions/runs/10088694351/job/27894872547

 Error: Can't use keyword 'self'. Use 'ImageShortcodeProvider' instead.
 ------ ----------------------------------------------------------------- 
  Line   Shortcodes/ImageShortcodeProvider.php                            
 ------ ----------------------------------------------------------------- 
  139    Can't use keyword 'self'. Use 'ImageShortcodeProvider' instead.  
 ------ ----------------------------------------------------------------- 

Issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should target 2.2?

@GuySartorelli
Copy link
Member Author

This code doesn't exist in 2.2

@emteknetnz emteknetnz merged commit 401277c into silverstripe:2 Jul 29, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/2/no-keyword-self branch July 29, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants