NEW Scaffold formfields for File and Image using new API #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/scaffold-relation-fields
branch
from
57a9026 to
d6c4a89
Compare
GuySartorelli
force-pushed
the
pulls/2/scaffold-relation-fields
branch
from
d6c4a89 to
6b81cdc
Compare
emteknetnz
requested changes
Jun 6, 2024
| DataObject $ownerRecord | ||
| ): FormField&FileHandleField { | ||
| $field = parent::scaffoldFormFieldForHasOne($fieldName, $fieldTitle, $relationName, $ownerRecord); | ||
| $field->setAllowedFileCategories('image/supported'); |
There was a problem hiding this comment.
Suggested change
| $field->setAllowedFileCategories('image/supported'); | |
| if ($field->hasMethod('setAllowedFileCategories')) { | |
| $field->setAllowedFileCategories('image/supported'); | |
| } |
Might as well do the same check as above since the FileHandleField could be changed with Injector
There was a problem hiding this comment.
setAllowedFileCategories() is defined in the FileHandleField interface, so we don't need to check for it.
setAllowedMaxFileNumber() isn't defined in that interface, which is why the condition for that method is there.
emteknetnz
approved these changes
Jun 7, 2024
GuySartorelli
added a commit
to creative-commoners/silverstripe-assets
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new API from silverstripe/silverstripe-framework#11269 to scaffold formfields for
ImageandFilehas_one relations.Note that there's no need to bump the framework dependency here - if installing this with framework 5.1 the old code path will be used instead, but the result will be the same.
Issue
DataObjectsubclass to define its own formfield when autoscaffolded from relation silverstripe-framework#11079