FIX Ensure manipulations start with base file #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out there's some special logic going on in manipulation that needs to take place starting with the File record. If you try to use the DBFile on its own without first performin a manipulation, the attributes applied to the file won't be passed down to subsequent manipulations.
This was referenced Jun 4, 2024
emteknetnz
approved these changes
Jun 4, 2024
GuySartorelli
added a commit
to creative-commoners/silverstripe-assets
that referenced
this pull request
Jul 17, 2024
It turns out there's some special logic going on in manipulation that needs to take place starting with the File record. If you try to use the DBFile on its own without first performin a manipulation, the attributes applied to the file won't be passed down to subsequent manipulations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out there's some special logic going on in manipulation that needs to take place starting with the
Filerecord. If you try to use theDBFileon its own without first performing a manipulation, the attributes applied to the file won't be passed down to subsequent manipulations.Changing the API here is fine because it's new API that hasn't been released yet.
Issue