Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Ensure public url slashes are forward slashes #603

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-asset-admin#1459

Issue will only affect webservers running windows

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test so we catch regressions

src/Flysystem/PublicAssetAdapter.php Show resolved Hide resolved
src/Flysystem/PublicAssetAdapter.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/2.2/public-url-slashes branch from 19b27ee to 7266f83 Compare May 15, 2024 00:41
@emteknetnz
Copy link
Member Author

Have added unit test

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 205c2d5 into silverstripe:2.2 May 15, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.2/public-url-slashes branch May 15, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants